Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ios): nbstore swift native binding #9211

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

Brooooooklyn
Copy link
Member

No description provided.

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.41%. Comparing base (8de0679) to head (752e697).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9211      +/-   ##
==========================================
- Coverage   51.45%   51.41%   -0.04%     
==========================================
  Files        2156     2156              
  Lines       97652    97653       +1     
  Branches    16379    16376       -3     
==========================================
- Hits        50244    50210      -34     
+ Misses      46017    45794     -223     
- Partials     1391     1649     +258     
Flag Coverage Δ
server-test 78.19% <ø> (-0.12%) ⬇️
unittest 31.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Brooooooklyn Brooooooklyn force-pushed the 12-19-feat_ios_nbstore_swift_native_binding branch 2 times, most recently from 6a2f32d to d4e7423 Compare December 25, 2024 04:53
@Brooooooklyn Brooooooklyn force-pushed the 12-19-feat_ios_nbstore_swift_native_binding branch from d4e7423 to aeec7bd Compare December 25, 2024 04:54
@Brooooooklyn Brooooooklyn marked this pull request as ready for review December 25, 2024 04:57
@Brooooooklyn Brooooooklyn force-pushed the 12-19-feat_ios_nbstore_swift_native_binding branch 4 times, most recently from c0a867a to f42b76b Compare December 25, 2024 14:45
Copy link
Member Author

Brooooooklyn commented Dec 25, 2024

Merge activity

  • Dec 25, 10:34 AM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Dec 27, 12:48 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 27, 1:50 AM EST: A user merged this pull request with the Graphite merge queue.

@Brooooooklyn Brooooooklyn force-pushed the 12-19-feat_ios_nbstore_swift_native_binding branch 5 times, most recently from 5072ed7 to a4a4f3d Compare December 26, 2024 12:50
@Brooooooklyn Brooooooklyn force-pushed the 12-19-feat_ios_nbstore_swift_native_binding branch from a4a4f3d to 0819866 Compare December 26, 2024 13:25
@Brooooooklyn Brooooooklyn requested a review from EYHN December 26, 2024 13:26
EYHN pushed a commit that referenced this pull request Dec 27, 2024
@EYHN EYHN force-pushed the 12-19-feat_ios_nbstore_swift_native_binding branch from 0a7c170 to 51c3b8c Compare December 27, 2024 06:21
@EYHN EYHN force-pushed the 12-19-feat_ios_nbstore_swift_native_binding branch from 51c3b8c to 752e697 Compare December 27, 2024 06:34
@graphite-app graphite-app bot merged commit 752e697 into canary Dec 27, 2024
61 checks passed
@graphite-app graphite-app bot deleted the 12-19-feat_ios_nbstore_swift_native_binding branch December 27, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants