Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: includable argument #108

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: includable argument #108

wants to merge 2 commits into from

Conversation

SychO9
Copy link
Contributor

@SychO9 SychO9 commented May 10, 2024

It would be nice to be able to use these methods for mutation since a use case (like ours) can be extensibility, so modifying what was already set by default.

Understandable if not fit here, since we can still add these through custom traits.

@SychO9 SychO9 changed the title feat: some flexible mutation feat: mutation methods May 10, 2024
@tobyzerner
Copy link
Owner

Not keen on addDefaultInclude and removeDefaultInclude, but would be open to making the $defaultInclude property public?

Happy for includable to have an argument.

@SychO9 SychO9 changed the title feat: mutation methods feat: includable argument Nov 2, 2024
@SychO9
Copy link
Contributor Author

SychO9 commented Nov 2, 2024

changes made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SychO9 @tobyzerner