Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low cloud tracking tobathon #486

Open
wants to merge 3 commits into
base: Tobathon2025
Choose a base branch
from

Conversation

JuliaKukulies
Copy link
Member

Our work from Tobathon2025, solves issue #483

This PR adds a new example jupyter notebook that demonstrate how tobac can be used to track shallow cumulus clouds using LES data from the Cloud Botany project.

This notebook follows the typical tracking steps feature detection, tracking and segmentation and includes an exmaple for a simple lifecycle analysis with the output data.

Thanks to Will Jones (@w-k-jones) and Milind Sharma

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.75%. Comparing base (0a163ba) to head (e08907b).

Additional details and impacted files
@@              Coverage Diff              @@
##           Tobathon2025     #486   +/-   ##
=============================================
  Coverage         60.75%   60.75%           
=============================================
  Files                23       23           
  Lines              3544     3544           
=============================================
  Hits               2153     2153           
  Misses             1391     1391           
Flag Coverage Δ
unittests 60.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Linting results by Pylint:

Your code has been rated at 8.24/10 (previous run: 8.24/10, +0.00)
The linting score is an indicator that reflects how well your code version follows Pylint’s coding standards and quality metrics with respect to the Tobathon2025 branch.
A decrease usually indicates your new code does not fully meet style guidelines or has potential errors.

@JuliaKukulies
Copy link
Member Author

@w-k-jones I have cleaned up the notebook and added some text. Please have a look and modify further if you want to change anything before we merge this. And do you know Milind's github username?

@w-k-jones
Copy link
Member

w-k-jones commented Mar 15, 2025

@w-k-jones I have cleaned up the notebook and added some text. Please have a look and modify further if you want to change anything before we merge this. And do you know Milind's github username?

Great, thanks, I really like the visualisations you've added! I'll have a look through any final changes on Monday

And Milind's github is @gewitterblitz

@gewitterblitz
Copy link

@JuliaKukulies I agree, the cleaned-up notebook looks ready to be added as an example for tracking shallow clouds.

Thank you so much to you and @w-k-jones for leading this effort!

@JuliaKukulies
Copy link
Member Author

@JuliaKukulies I agree, the cleaned-up notebook looks ready to be added as an example for tracking shallow clouds.

Thank you so much to you and @w-k-jones for leading this effort!

Great, thanks for your feedback @gewitterblitz !

@JuliaKukulies
Copy link
Member Author

@w-k-jones I have cleaned up the notebook and added some text. Please have a look and modify further if you want to change anything before we merge this. And do you know Milind's github username?

Great, thanks, I really like the visualisations you've added! I'll have a look through any final changes on Monday

And Milind's github is @gewitterblitz

Sounds good @w-k-jones and thanks for your feedback! I will also need to check why the notebook checks fail here before we merge this

@w-k-jones w-k-jones linked an issue Mar 18, 2025 that may be closed by this pull request
@JuliaKukulies
Copy link
Member Author

JuliaKukulies commented Mar 18, 2025

@w-k-jones do you have any more changes that you wanted to add to this notebook?

Also, the checks fail because of the missing library intake (and eurec4a). Would you suggest to just add the additional dependencies in example_requirements.txt or environment-ci.yml or both?

@w-k-jones
Copy link
Member

@w-k-jones do you have any more changes that you wanted to add to this notebook?

Also, the checks fail because of the missing library intake (and eurec4a). Would you suggest to just add the additional dependencies in example_requirements.txt or environment-ci.yml or both?

Yep, I think both intake==0.7.0 and intake-xarray==0.7.0 are required, I'll add them to both and check that it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example notebook for tracking low clouds
3 participants