-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vim mode navigation for horizontal sidebar css themes such as Zenith (work in progress) #5
Conversation
ce6c1e2
to
3e96f36
Compare
My understanding is that those panels are just subsections of sidebar displayed differently, right? I think it's useful to have a behavior to switch between those regardless (in fact it's one of the feature requests I had) |
Yeah, I think this works for switching between sidebar panels even with the default theme. The only caveat is that this branch fails to vertically scroll in the sidebar, because each "panel" manages it's own scrolling. To elaborate, the current DOM structure is something like: <div id="roam-article" panel="MAIN" vertical-scroll>
Main page
</div>
<div id="roam-right-sidebar-content" panel="SIDE" vertical-scroll>
<div>Side page A</div>
<div>Side page B</div>
</div> The horizontal CSS theme I'm using does something like this: <div id="roam-article" panel="MAIN" vertical-scroll>
Main page
</div>
<div id="roam-right-sidebar-content">
<div panel="Page A" vertical-scroll>Side page A</div>
<div panel="Page B" vertical-scroll>Side page B</div>
</div> Scrolling panel "Page A" while using the default theme doesn't move the scrollbar of the Some options I can think of:
|
what I had in mind is closest to
|
c842d18
to
1c52dba
Compare
df9d279
to
cc694e2
Compare
69f7c07
to
f8e7c11
Compare
cc694e2
to
2f85f93
Compare
f8e7c11
to
023f7e6
Compare
2f85f93
to
a465942
Compare
023f7e6
to
b1727c8
Compare
a465942
to
20065bd
Compare
b1727c8
to
a1a481d
Compare
20065bd
to
6737e0d
Compare
c3d1518
to
5a52ce6
Compare
2a44cdc
to
1290791
Compare
5a52ce6
to
0db4748
Compare
1290791
to
16e4868
Compare
84153a8
to
5d4935f
Compare
16e4868
to
e672de9
Compare
Thanks for the feature. I'm currently using the Vim mode with horizontal layout. |
Closing in favor of roam-unofficial#160 |
The current
h
andl
shortcuts don't really with with CSS themes with horizontal layout, such as ZenithHere is a demo of navigating left / right among sidebar panels:
https://www.youtube.com/watch?v=4t9cy_A3-QI
I wonder if we can detect whether the user is using horizontal mode or not, and adjust the behavior or
h
/l
accordingly.