Override client service saving actions to use password encoder to save client secret #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifmolina
changed the title
|
Hello, have you been able to review the proposed solution? Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following pull request resolves the issue Password encoder doesn't work from Web Interface
The solution is to overwrite the client service of the project mitreid-connect / OpenID-Connect-Java-Spring-Server so that when saving a new client or when updating an existing client, the client secret is stored encoded using the configured encoder for clients.
In the case of having no password encoder configured, the NoOpPasswordEncoder is used, which stores the password as plain text.
This solution is merely temporary since the objective is to modify the mitreid-connect / OpenID-Connect-Java-Spring-Server project so that an instance of a PasswordEncoder can be injected.