Improve paging: Less config in template, add generic arguments for producer #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d22
commented
May 24, 2014
d22
commented
- Move config to views, add key to config to template tag (similar to producer)
- Add generic arguments for the list producer
|
|
||
| # get page count from stat producer | ||
| sp = stat_producer_dict.get(stat_producer) | ||
| sp = conf['stat_producer'] |
There was a problem hiding this comment.
If no value for the key 'stat_producer' is found, a KeyError is raised. Is this what you want to check, or is there a default value of None?
There was a problem hiding this comment.
Oh, you're right. I'll fix this (for this, and the follwing occurences).
|
Good to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.