Skip to content

-Fix R_NO_REMAP warning: "R_NO_REMAP" redefined compilation warning #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

tylermorganwall
Copy link
Contributor

Compiling RcppExports.cpp when linking RcppThread can lead to a warning about redefining R_NO_REMAP: this PR adds a preprocessor guard to ensure it's only defined once.

See the following build logs (below is relevant excerpt):

2024-12-29T17:10:15.1806052Z g++  -std=gnu++20 -I"C:/R/include" -DNDEBUG  -I'D:/a/_temp/Library/Rcpp/include' -I'D:/a/_temp/Library/RcppThread/include' -I'D:/a/_temp/Library/progress/include' -I'D:/a/_temp/Library/spacefillr/include' -I'D:/a/_temp/Library/testthat/include'   -I"C:/rtools44/x86_64-w64-mingw32.static.posix/include"  -DRAY_REPRODUCE_PERLIN -DSTRICT_R_HEADERS -DRAY_WINDOWS -DHAS_SSE -DRAYSIMD -DRAYSIMDVECOFF -DR_NO_REMAP   -O2 -Wall  -mfpmath=sse -msse2 -mstackrealign  -c RcppExports.cpp -o RcppExports.o
2024-12-29T17:10:15.2190025Z In file included from D:/a/_temp/Library/RcppThread/include/RcppThread.h:9,
2024-12-29T17:10:15.2190688Z                  from RcppExports.cpp:4:
2024-12-29T17:10:15.2191504Z D:/a/_temp/Library/RcppThread/include/RcppThread/RMonitor.hpp:10: warning: "R_NO_REMAP" redefined
2024-12-29T17:10:15.2192987Z    10 | #define R_NO_REMAP
2024-12-29T17:10:15.2193273Z       | 
2024-12-29T17:10:15.2193735Z <command-line>: note: this is the location of the previous definition

@tnagler tnagler merged commit b1f8440 into tnagler:main Dec 30, 2024
5 checks passed
@tnagler
Copy link
Owner

tnagler commented Dec 30, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants