Check netem cmd sucess and pytest-timeout pkg existence #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriy-zainullin
force-pushed
the
check_netem_cmd_and_pytest-timeout
branch
from
fc75ec0 to
21a2bf1
Compare
Mostly useful for macos case. Because there's no netem, tests seem to be flying on macs, while there's no real packet loss, reorder or duplication.
valeriy-zainullin
force-pushed
the
check_netem_cmd_and_pytest-timeout
branch
from
21a2bf1 to
b9bc5ca
Compare
If that is not the case, timeouts won't be checked! Because the decorator that specifies the timeout comes from a pytest plugin that is not installed. pytest displays a warning in that case.
valeriy-zainullin
force-pushed
the
check_netem_cmd_and_pytest-timeout
branch
from
b9bc5ca to
72411ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Изменения добавляют проверку успешности выполнения netem. В частности, отловим отсутствие утилиты
tc, если кто запускает с мака или другой ОС.Еще добавим проверку того, что пакет
pytest-timeoutустановлен. Без него таймауты не работают (не должны работать), если кто-то запускает на локальном линуксе (правда, выйдет куча варнингов, чтоpytest.mark.timeoutне зарегистрирован). Проверяется только при запуске через pytest, в функции настройки конфига (ее вызывает сам pytest).Требуется проверить, что на маке отлавливается отсутствие netem и выходит сообщение, что надо запускать на линуксе. У меня мака нет, не могу проверить.