This repository has been archived by the owner on Apr 25, 2022. It is now read-only.
CephBlockPool CR #16
Draft
CephBlockPool CR #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/L
- FYI, kubebuilder generates the default path to import api package following the repo name of the PROJECT file. When you create an API for a new CR, look closely on the import module name under the controllers folder when you hit "package blah is not in GOROOT" error message.
- Kubebuilder generates the default path to import api package in controller go files following the repo name of the PROJECT file. Therefore renaming domain and repo is needed in order to reduce manual labor to fix import statement after generating controller codes for a new CR.
github-actions
bot
added
size/XL
hbinkim
force-pushed
the
blockpool
branch
3 times, most recently
from
01bd2af to
74e9aec
Compare
github-actions
bot
added
size/XXL
- update existing CRD CephCluster version v1beta1 to v1 - apply default CRD version to v1
hyoung-90
reviewed
May 25, 2021
hyoung-90
reviewed
May 25, 2021
| @@ -1,7 +1,10 @@ | |||
| domain: tmax.io | |||
| repo: hypersds-operator | |||
| domain: github.com | |||
There was a problem hiding this comment.
It seems to be necessary to check if there is no association with the apiVersion of cr. Specifically, it means group of crd.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done
Todo in this PR
Next PR