Update bibtex-completion.el for parsebib.el 6.0 #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this PR. I'll merge it when you give me the green light. |
|
Thanks. I'd like to merge the new parser some time over the weekend. I'll let you know when I do. |
|
I've just merged the new parser and pushed to Github. |
|
Merged. Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mentioned in issue #452 , I've made some changes to the
parsebib.elAPI that affectbibtex-completion.el. This PR fixes those issues. Obviously, it shouldn't be merged until I push the newparsebib.elto master.I've only changed the relevant function calls. Given the purpose of
bibtex-completion.el, it would probably make sense to useparsebib-collect-bib-entriesandparsebib-collect-strings, but that would require a bigger change (e.g.,parsebib-collect-bib-entriescan do some of the things thatbibtex-completion-prepare-entrydoes, it seems), so you probably have a better idea if that's worth it.