New parsebib.el parser
#452
Comments
|
I just find a bug that So if we want fix it, we should do the change on |
Depends. I submitted a PR, but it looks like it hasn't been merged yet. Keeping |
|
Just merged the PR. Thank you Joost!! |
|
Hi, I m having the issue that when I invoke I got this issue last night and came here to notice there was an update on the dependency However, today I just updated the I can provide further info but anything I can try? Thanks for helping. |
|
I don't know about helm (I don't use it), but if |
|
I'm having the same problem. I reproduce in the following way:
emacs -Q \
-l ~/.cache/emacs/straight/build/s/s.elc \
-l ~/.cache/emacs/straight/build/dash/dash.elc \
-l ~/.cache/emacs/straight/build/f/f.elc \
-l ~/.cache/emacs/straight/build/biblio-core/biblio-core.elc \
-L ~/.cache/emacs/straight/build/biblio/ \
-l ~/.cache/emacs/straight/build/biblio/biblio.elc \
-l ~/.cache/emacs/straight/build/parsebib/parsebib.elc \
-L ~/.cache/emacs/straight/build/org/ \
-l ~/.cache/emacs/straight/build/bibtex-completion/bibtex-completion.el \
-L ~/.cache/emacs/straight/build/helm/ \
-L ~/.cache/emacs/straight/build/helm-core/ \
-L ~/.cache/emacs/straight/build/async/ \
-l ~/.cache/emacs/straight/build/helm-bibtex/helm-bibtex.elc
@Comment @Article{l2024-hire,
@Comment author = {{L}, Yashas Samaga B and {Yerram}, Varun and {You}, Chong and {Bhojanapalli}, Srinadh and {Kumar}, Sanjiv and {Jain},
@Comment Prateek and {Netrapalli}, Praneeth},
@Comment title = {{HiRE: High Recall Approximate Top-$k$ Estimation for Efficient Llm Inference}},
@Comment journal = {arXiv e-prints},
@Comment year = 2024,
@Comment eid = {arXiv:2402.09360},
@Comment month = feb,
@Comment pages = {arXiv:2402.09360},
@Comment doi = {10.48550/arXiv.2402.09360},
@Comment eprint = {2402.09360},
@Comment primaryclass = {cs.LG},
@Comment archiveprefix = {arXiv},
@Comment timestamp = {2024-11-14T11:08:04-0500}
@Comment }
|
|
I'm also having the same issue. I had pinned parsebib to 4.7, but this bibtex-completion update forced parsebib back to 6. I don't use helm, but org-ref has these as dependences. If you need help testing let me know...running Emacs on macos compiled from the master branch today. |
My emacs version is |
|
Well, the problem is not with |
In parsebib.el 4.7 / 5.0, the function parsebib-find-next-item leaves point after the @-sign when it finds an item. In parsebib.el 6.0, it leaves point *before* the @-sign. Therefore, the caller must advance point if the item is not read, otherwise parsebib-find-next-item will keep finding the same item. This fixes the problems reported in tmalsburg#452 and jkitchin/scimax#510.
|
I found the cause of the problem and created a PR to fix it. I hope @tmalsburg can merge this PR soon, and I sincerely hope I didn't overlook anything else... |
|
@joostkremers FYI, I just applied your PR to my instance of bibtex-completion and verified it works in my case. Thanks! |
I downloaded your PR and rename the original installed file to |
Hmm, that's a bit harder for me to debug, because I don't use helm. Position (2,8) would be the first |
|
#454 is merged. Thank you! |
Don't thank me yet... There's still a bug that needs to be squashed. 😞 |
Thanks for helping so far. Here is the backtrace with the minimal |
|
It worked for me. |
Would you mind giving the versions of the packages you have on your system? There may be obsolete dependency packages on my end. I usually use melpa repos. What is your emacs version? thanks |
|
Thanks @lnguyen4 , that was very helpful. I indeed found another bug that was introduced by the new The reason for these bugs is that I checked the places where My apologies for all the hassle this is causing and my thanks to all of you for your patience! |
|
No problem. Emacs rules! :). And I updated the el file from your PR. It works like usual now. I can select all the actions on the entry and no error happens. Thanks a lot. |
I see. My bibtex-completion is pretty recent.
|
I suspect that this is from melpa and does not catch the most recent change on https://github.com/tmalsburg/helm-bibtex which is updated <1d ago I used straight to download from the github daily. |
Hi @tmalsburg ,
bibtex-completion.eldepends onparsebib.el, so I wanted to give you a heads-up: I've ripped out the pretty hairy regexp-based parser code and replaced it with a simple recursive descent parser. The new parser works well, and the tests included inparsebiball pass, but with this kind of thing there's always a risk of regressions, of course.I haven't merged the new code yet, but once I do, you may get bug reports from users that are ultimately caused by
parsebib.el. If that happens, just send them to me, or key me in in the discussion.Some functions have also changed signature, especially
parsebib-read-entry, which is used inbibtex-completion.el. You may want to consider usingparsebib-parse-bib-bufferorparsebib-collect-bib-entriesinstead, which will get you all entries in a single function call.If you have a
.bibfile that you would like to test the new code with before I do the merge, I'd be happy to do that, or if you prefer, you can check out the code here.The text was updated successfully, but these errors were encountered: