Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(no-describe-variables): Check variable declarations in arrow functions #358

Merged
merged 1 commit into from
Sep 26, 2022
Merged

fix(no-describe-variables): Check variable declarations in arrow functions #358

merged 1 commit into from
Sep 26, 2022

Conversation

osamayelk
Copy link
Contributor

Description

This fixes the issue #233 for arrow function definitions in describe

How has this been tested?

I wrote unit tests in Mocha for the new rules

Types of changes

  • Test change (non-breaking change which adds additional test scenarios)
  • Refactor change (non-breaking change updates coding styles)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have ran npm run test and everything passes
  • My code follows the code style of this project
  • I have updated the documentation where necessary
  • I have read the CONTRIBUTING document
  • I have added tests to cover my changes
  • All new and existing tests pass

DianaSuvorova
DianaSuvorova approved these changes Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@DianaSuvorova DianaSuvorova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@DianaSuvorova DianaSuvorova merged commit f77738d into tlvince:master Sep 26, 2022
@osamayelk osamayelk deleted the fix/no-describe-variables branch September 26, 2022 18:03
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 4.1.4-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DianaSuvorova DianaSuvorova DianaSuvorova approved these changes

Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osamayelk @DianaSuvorova