Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return valid json in Server fixture #652

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Return valid json in Server fixture #652

merged 3 commits into from
Oct 25, 2024

Conversation

heeckhau
Copy link
Member

  • return json instead of string
  • removed trailing whitespace
  • use a constant for the default port
  • give binary a better name

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 54.55%. Comparing base (6344410) to head (dd34c28).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
crates/server-fixture/server/src/lib.rs 91.83% 4 Missing ⚠️
crates/server-fixture/server/src/main.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #652      +/-   ##
==========================================
+ Coverage   54.35%   54.55%   +0.19%     
==========================================
  Files         192      192              
  Lines       20473    20518      +45     
==========================================
+ Hits        11129    11194      +65     
+ Misses       9344     9324      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heeckhau heeckhau requested review from th4s and yuroitaki and removed request for yuroitaki and th4s October 25, 2024 08:38
Copy link
Member

@yuroitaki yuroitaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice stuff!

crates/server-fixture/server/Cargo.toml Outdated Show resolved Hide resolved
crates/server-fixture/server/src/lib.rs Show resolved Hide resolved
crates/server-fixture/server/src/lib.rs Show resolved Hide resolved
@heeckhau heeckhau requested a review from th4s October 25, 2024 13:39
* return json instead of string
* removed trailing whitespace
* use a constant for the default port
* give binary a better name
@heeckhau heeckhau merged commit 30e4e37 into dev Oct 25, 2024
8 checks passed
@heeckhau heeckhau deleted the server_fixture_json branch October 25, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants