test: add browser benches #570
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heeckhau
reviewed
Aug 20, 2024
themighty1
force-pushed
the
browser-bench
branch
from
c624975
to
07f32bb
Compare
themighty1
force-pushed
the
browser-bench
branch
from
07f32bb
to
b8cb85c
Compare
|
It appears that the bench would hang occasionally. I'll have to investigate it and then we can proceed with review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOT READY FOR REVIEW: sometimes a bench instance hangs. Needs investigation.
This PR adds the functionality to benchmark the prover running in a browser.
binarycontains the binaries and the native benchlibrarycontains logic shared by the native and the browser benchbrowsercontains thenativemodule which drives the browser and loads the wasm module.The docker image was tested only on Linux.
The new github workflow was tested here https://github.com/themighty1/tlsn/actions/workflows/bench-browser.yml