Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add job for building and uploading tlsn-wasm build result #553

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

heeckhau
Copy link
Member

@heeckhau heeckhau commented Aug 1, 2024

No description provided.

@heeckhau heeckhau force-pushed the wasm_build branch 2 times, most recently from 7c01463 to 25fcca9 Compare August 1, 2024 13:17
@heeckhau heeckhau force-pushed the wasm_build branch 2 times, most recently from 48231f8 to b35df6f Compare August 2, 2024 14:18
@sinui0
Copy link
Member

sinui0 commented Aug 5, 2024

Shouldn't this be something that occurs on release and not part of CI?

Should this be taken care of in tlsn-js instead?

@heeckhau
Copy link
Member Author

Shouldn't this be something that occurs on release and not part of CI?

Should this be taken care of in tlsn-js instead?

Doing it here has the advantage that a build is available for every code change.

This would also allow us to easily add it as an artifact to releases. The tlsn-js job can then simply fetch it.

The automation could look something like this:

name: Create Draft Release

on:
  push:
    tags:
      - 'v*'  # Triggers on version tags like v1.0.0

jobs:
  release:
    runs-on: ubuntu-latest

    steps:
    - name: Download build artifacts
      uses: actions/download-artifact@v4
      with:
        name: tlsn-wasm-pkg

    - uses: ncipollo/release-action@v1
      with:
        artifacts: "tlsn-wasm-pkg.zip"
        name: ${{ github.ref }}
        draft: true
        prerelease: true
        generateReleaseNotes: true

@sinui0
Copy link
Member

sinui0 commented Sep 19, 2024

@0xtsukino thoughts on this?

@0xtsukino
Copy link
Collaborator

@0xtsukino thoughts on this?

@heeckhau and I discussed after his comment and we agreed at at least for the near future it would be easier for me to simply run the build locally, test them via npm link, and then publish to npm as tlsn-wasm on my machine.

tlsn-js will then just have a dependency on tlsn-wasm. tlsn-wasm will see little to no changes after each release, and tlsn-js might see more integration related bug fixes, and is purposely built for direct integration into tlsn-extension-esque architecture.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.35%. Comparing base (1d66359) to head (ba3f41b).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #553   +/-   ##
=======================================
  Coverage   54.35%   54.35%           
=======================================
  Files         192      192           
  Lines       20473    20473           
=======================================
  Hits        11129    11129           
  Misses       9344     9344           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants