WIP: Example plugin in Rust #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th4s
approved these changes
Sep 18, 2024
examples/fitbit-rs/src/utils.rs
Outdated
Comment on lines
21
to
25
| if let Some(host_cookies) = cookies.get(hostname) { | ||
| Ok(host_cookies.clone()) | ||
| } else { | ||
| Err(format!("Cannot find cookies for {}", hostname)) | ||
| } |
There was a problem hiding this comment.
Here we can do
cookies
.get(hostname)
.cloned()
.ok_or_else(|| format!("Cannot find cookies for {}", hostname))
examples/fitbit-rs/src/utils.rs
Outdated
| use extism_pdk::*; | ||
|
|
||
| pub fn get_cookies_by_host(hostname: &str) -> Result<HashMap<String, String>, String> { | ||
| let cookies_result = get("cookies"); |
There was a problem hiding this comment.
If the function would return anyhow::Error instead of String like extism-pdk does, we can make use of ?
let cookies = get("cookies")?;But even without it we can do
let cookies = get("cookies").map_err(|err| err.to_string())?;
examples/fitbit-rs/src/utils.rs
Outdated
Comment on lines
10
to
14
| let cookies_json = match cookies_result { | ||
| Ok(Some(json_str)) => json_str, | ||
| Ok(None) => return Err("No cookies found in the configuration.".to_string()), | ||
| Err(e) => return Err(format!("Error retrieving cookies: {}", e)), | ||
| }; |
There was a problem hiding this comment.
Then this becomes
let cookies = cookies.ok_or_else(|| "No cookies found in the configuration.".to_string())?;| } | ||
|
|
||
| #[plugin_fn] | ||
| pub fn start() -> FnResult<Json<bool>> { |
There was a problem hiding this comment.
Instead of a bool it would be nicer to have a anyhow::Result<()>. Then you can also add error messages similarly to how you do in utils.rs.
| } | ||
|
|
||
| #[plugin_fn] | ||
| pub fn two() -> FnResult<Json<Option<String>>> { |
There was a problem hiding this comment.
This function never returns an error, but logs it. Is this because of the plugin_fn constraints?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.