Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add running notary server instruction. #51

Merged
merged 7 commits into from
Dec 19, 2023
Merged

Add running notary server instruction. #51

merged 7 commits into from
Dec 19, 2023

Conversation

yuroitaki
Copy link
Member

No description provided.

@yuroitaki yuroitaki requested a review from heeckhau December 11, 2023 08:05
Copy link
Member

@heeckhau heeckhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I feel like it is worth mentioning that port 7047 should be open on the firewall

src/developers/notary_server.md Outdated Show resolved Hide resolved
src/developers/notary_server.md Outdated Show resolved Hide resolved
@yuroitaki yuroitaki requested a review from heeckhau December 14, 2023 02:35
Copy link
Member

@heeckhau heeckhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements thanks!

After reading your latest changes, I think it would be better to talk about the keys and certificates first. They will need these files before they can run the server.
So it would be better to list these files first with a short explanation of what each required file exactly is.

@yuroitaki yuroitaki requested a review from heeckhau December 18, 2023 07:50
src/developers/notary_server.md Outdated Show resolved Hide resolved
src/developers/notary_server.md Outdated Show resolved Hide resolved
src/developers/notary_server.md Outdated Show resolved Hide resolved
@yuroitaki yuroitaki requested a review from heeckhau December 18, 2023 09:14
Copy link
Member

@heeckhau heeckhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yuroitaki yuroitaki merged commit f050bec into main Dec 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants