Key exchange update #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heeckhau
requested changes
Sep 7, 2023
|
|
||
| Below is the 3-party ECDH protocol between $S$, $P$ and $V$, enabling $P$ and $V$ to arrive at shares of $\mathbb{pms}$. |
There was a problem hiding this comment.
Suggested change
| Below is the 3-party ECDH protocol between $S$, $P$ and $V$, enabling $P$ and $V$ to arrive at shares of $\mathbb{pms}$. | |
| $S$, $P$ and $V$ perform the 3-party ECDH protocol together. The result is that both $P$ and $V$, each have a share of the $\mathbb{pms}$. The 3-party ECDH protocol consists of following steps: |
There was a problem hiding this comment.
I feel like we should avoid 3-party here. I'd say the server plays its normal role. The TLS-client is a 2PC between the Prover and the Verifier.
Note that the diagram also uses 2PC
themighty1
approved these changes
Sep 8, 2023
|
|
||
| Below is the 3-party ECDH protocol between $S$, $P$ and $V$, enabling $P$ and $V$ to arrive at shares of $\mathbb{pms}$. |
There was a problem hiding this comment.
Can we mention that the notation is from Wikipedia, so ppl could have wikipedia open and easier follow the explanation.
|
|
||
|
|
||
| 1. $S$ sends its public key $Q_b$ to $P$, and $P$ forwards it to $V$ | ||
| 2. $P$ picks a random private key share $d_c$ and computes a public key share $Q_c = d_c * G$ |
There was a problem hiding this comment.
Can we change the diagram to also have the word "share" there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our key exchange section