Update completion path in README.md #385
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix install path
blueskyson
approved these changes
Jul 16, 2023
kbdharun
approved these changes
Jul 16, 2023
agnivade
reviewed
Jul 18, 2023
| @@ -124,7 +124,8 @@ users, so let's start with that. | |||
|
|
|||
| ``` | |||
| mkdir -p $ZSH_CUSTOM/plugins/tldr | |||
| ln -s bin/completion/zsh/_tldr $ZSH_CUSTOM/plugins/tldr/_tldr | |||
There was a problem hiding this comment.
This path assumes you have a local clone of the codebase. But maybe that wasn't clear. I'd like to keep both versions of this. Maybe we can clarify and say that if you have a local clone of the repo, use bin/completion/zsh/_tldr or else use $(npm config get prefix)/lib/node_modules/tldr/bin/completion/zsh/_tldr once you have installed the tool?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix completion path
Description
Change unclear relative path to real absolute path for user setup.
Checklist
npm run test:all)