Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP: Create proof step markers for USE statements involving facts. #193

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

kape1395
Copy link
Collaborator

@kape1395 kape1395 commented Jan 4, 2025

Fixes #192

image

@kape1395 kape1395 requested a review from ahelwer January 4, 2025 13:06
@kape1395 kape1395 self-assigned this Jan 4, 2025
@kape1395 kape1395 added the bug An error, usually in the code. label Jan 4, 2025
@kape1395
Copy link
Collaborator Author

kape1395 commented Jan 4, 2025

Some changes are caused by the ocamlformat, which started formatting the comments after its version was updated. I will create another PR to re-format other files under ./lsp.

@ahelwer
Copy link
Collaborator

ahelwer commented Jan 6, 2025

Is there a reason this was not done previously? Are USE steps exposed in some strange way through the parse tree? Was it just not implemented yet, as shown by this line?

  | Proof.T.Use (_, _) -> (None, acc)

@kape1395
Copy link
Collaborator Author

kape1395 commented Jan 6, 2025

I skipped them when implementing the LSP mainly because these steps were not marked "green" in the toolbox. So, I assumed they produce no proof obligations. Now I understand they do.

@kape1395 kape1395 merged commit 132d225 into main Jan 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error, usually in the code.
Development

Successfully merging this pull request may close these issues.

LSP: USE should be used as separate steps
2 participants