Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flexible source dir #72

Open
wants to merge 5 commits into
base: app-ns-3.36+
Choose a base branch
from
Open

Conversation

rukyr97
Copy link
Contributor

@rukyr97 rukyr97 commented Oct 14, 2022

With this patch, users no longer need to move the full ns3-gym repo into the contrib folder of ns-3. Instead, they can use symbolic links.
This wasn't possible without this patch because the code was dependent of the output of os.getcwd(). Herein, the default behavior remains the same. However, we can specify with the optional source_dir parameter, what is the working directory that we want to define as the source directory.

@pgawlowicz pgawlowicz force-pushed the app-ns-3.36+ branch 2 times, most recently from 72996bb to 6007f4b Compare May 9, 2023 18:50
@pgawlowicz
Copy link
Contributor

pgawlowicz commented May 9, 2023

Thank you for explanation. Indeed, might be a nice feature for some users. Could you clean the commit history and provide only 1 commit with the feature? The two first commits are already in main repo, so just the code allowing to set the src dir.

@rukyr97 rukyr97 force-pushed the app-ns-3.36+ branch 2 times, most recently from e67cfa3 to bc10b33 Compare May 10, 2023 09:33
@rukyr97
Copy link
Contributor Author

rukyr97 commented May 18, 2023

It is done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants