Append/Caching Bug #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Creating a diamond-like connection pattern resulted in the Cache creating multiple instances of the same filter, but only applying the input to one of them resulting in hard-to-find errors - AppendFilter did not work properly and could not work with direct data structures Minor bugfix: VTK Writers not working
|
Thanks for the workaround and fixes! Seems to be a manifestation of one of the weaknesses of the current update process. Updating will be changed in #46 later on, meanwhile this seems good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the issue in #55, where creating diamond-like connection pattern results in the Cache creating multiple instances of the same filter, but only applying the input to one of them. This fix introduces a new update ID that only clears the cache for each object if the update ID does not match the last update ID. I'm not sure if this conflicts with #46
Minor fixes: