-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue 3 compatibility #64
base: main
Are you sure you want to change the base?
Conversation
@@ -39,7 +39,7 @@ const helpers = { | |||
return ( | |||
received && | |||
typeof(received) === 'object' && | |||
typeof(received.isVueInstance) === 'function' | |||
typeof(received.html) === 'function' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this. I would prefer something more Vue specific
@@ -36,10 +37,10 @@ | |||
"eslint-plugin-jsdoc": "^24.0.0", | |||
"eslint-plugin-vue": "^6.2.2", | |||
"jest": "24.9.0", | |||
"vue": "^2.6.11", | |||
"typescript": "^3.8.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like typescript
being required as a dependency. Looking forward to removing this.
Any progress on this? |
I've not had time (or need) to work on this in a while. When I start working on a large Vue 3 project I'll inevitably need to come back to this. In the mean time, I've hacked it into one project, you can use it as a reference.
|
@doutatsu Almost done with a new Vue 3/Vite/ESM re-write of this library. If you want to try it out: |
Notes:
.html()
no longer seems to include proper whitespace/returns, making formatting extremely difficultshallowMount
placeholders while we wait on VTU-Next beta to be released