Implement merge #154
Open
Implement merge #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srph
commented
Apr 29, 2017
| @@ -4,7 +4,7 @@ | |||
| "description": "common javascript utils that can be required selectively that assume es5+", | |||
| "main": "index.js", | |||
| "scripts": { | |||
| "test": "lab -c -t 100 -a code", | |||
| "test": "lab --leaks -c -t 100 -a code", | |||
There was a problem hiding this comment.
Tests can't be ran without --leaks. I can remove this once I'm done with most items.
There was a problem hiding this comment.
I think we need to update lab. Happy to switch off too. I've been having this problem with other projects. You can leave the leak flag..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #151
Supported
merge({ text })merge('fetch', { loading: false })merge(state.comments, '34.replies.5', { text })Todo
merge(state.comments, { '0.replies.1': { text } }))Are there any other important features I missed in the list?