solicy-vauled deposit and withdraw #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebuster22
requested changes
Aug 20, 2024
There was a problem hiding this comment.
Following things needed before this PR can be approved:
- Tests for the function created
- Resolve the comments
- Add round logic: https://specifications.vercel.app/docs/intro/how-titus-works#functioning-of-options-on-titus-finance
- Add a admin function to increment the round manually (This is more like a stub which will be removed going forward.)
| @@ -0,0 +1,107 @@ | |||
| module SolicyAdminAddress::SolicyVault { | |||
There was a problem hiding this comment.
It's not Solicy, it's Titus. Please use Titus.
| }); | ||
| } | ||
|
|
||
| public entry fun deposit<CoinType>(account: &signer, amount: u64) acquires AppInfo, VaultInfo { |
There was a problem hiding this comment.
Can you add a comment in the code line, where we are storing a map between depositor address and amount of coins deposited by the depositor?
| }; | ||
| } | ||
|
|
||
| public entry fun withdraw<CoinType>(account: &signer, amount: u64) acquires VaultInfo, AppInfo { |
There was a problem hiding this comment.
we need to ensure, the depositor cannot withdraw more than what they have deposited.
Also, rename this function to instant_withdraw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code contains the functions to deposit, withdraw, pause and unpause the contracts.