Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate cross-origin IFrames #33

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

e9x
Copy link
Contributor

@e9x e9x commented Feb 25, 2023

This will require more thorough testing, but it appears to be effective based on my testing.

In order to implement this, iframe baseURIs must be recognized.
location will still report about:blank, but the base URI or __uv.base will be reliable
@e9x e9x linked an issue Feb 25, 2023 that may be closed by this pull request
@e9x e9x force-pushed the 25-iframe-windows-can-easily-be-hijacked branch from 5f3fbee to 4568101 Compare February 28, 2023 03:11
@strubium
Copy link

Pro gamer security vulnerability, very nice.

Don't know why this hasn't been merged, seems to work.

@tytech039
Copy link

giphy

itschasa

This comment was marked as outdated.

@itschasa
Copy link

I found this to give issues when doing recaptcha, anyone else the same?

@e9x
Copy link
Contributor Author

e9x commented Apr 27, 2024

I found this to give issues when doing recaptcha, anyone else the same?

yea that's the main reason why I've been hesitant to merge this, captchas don't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IFrame windows can easily be hijacked.
4 participants