fix: change to use AppKit to show about window (#802)

tisfeng · Feb 3, 2025 · fe248ee · fe248ee
1 parent 2a04958
commit fe248ee
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 10 deletions.
diff --git a/Easydict/App/EasydictApp.swift b/Easydict/App/EasydictApp.swift
@@ -75,15 +75,6 @@ struct EasydictApp: App {
                 .environmentObject(languageState)
                 .environment(\.locale, .init(identifier: I18nHelper.shared.localizeCode))
         }
-
-        // About window
-        Window("setting.about", id: .aboutWindowId) {
-            AboutTab()
-                .frame(width: 500, height: 220)
-                .disableWindowMinimize()
-        }
-        .windowResizability(.contentSize)
-        .windowStyle(.hiddenTitleBar)
     }
 
     // MARK: Private

diff --git a/Easydict/Swift/View/MenuView/MainMenuCommand.swift b/Easydict/Swift/View/MenuView/MainMenuCommand.swift
@@ -25,7 +25,7 @@ struct EasydictMainMenu: Commands {
         // Override About
         CommandGroup(replacing: .appInfo) {
             Button {
-                openWindow(id: .aboutWindowId)
+                HostWindowManager.shared.showAboutWindow()
             } label: {
                 Text("menubar.about")
             }

diff --git a/Easydict/Swift/View/Window/HostWindowManager.swift b/Easydict/Swift/View/Window/HostWindowManager.swift
@@ -73,9 +73,17 @@ final class HostWindowManager {
 // MARK: - Window Creation Methods
 
 extension HostWindowManager {
+    /// Show the acknowledgements window.
     func showAcknowWindow() {
         showWindow(windowId: .acknowledgementsWindowId) {
             AcknowListView()
         }
     }
+
+    /// Show the About window.
+    func showAboutWindow() {
+        showWindow(windowId: .aboutWindowId, width: 500, height: 220, resizable: false) {
+            AboutTab()
+        }
+    }
 }