Merge branch 'dev' into fix-sparkle-alert

tisfeng · Feb 5, 2025 · 900a1d5 · 900a1d5
2 parents 81e7503 + fc3fdd6
commit 900a1d5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/Easydict/Swift/Feature/Configuration/Configuration.swift b/Easydict/Swift/Feature/Configuration/Configuration.swift
@@ -310,7 +310,7 @@ class Configuration: NSObject {
             }
             .store(in: &cancellables)
 
-        Defaults.publisher(.allowCrashLog, options: [])
+        Defaults.publisher(.allowCrashLog, options: [.initial])
             .removeDuplicates()
             .sink { [weak self] _ in
                 self?.didSetAllowCrashLog()

diff --git a/Easydict/objc/Utility/EZLog/EZLog.m b/Easydict/objc/Utility/EZLog/EZLog.m
@@ -53,9 +53,13 @@ + (void)setupSentry {
 
 + (void)setCrashEnabled:(BOOL)enabled {
     BOOL isEnabled = enabled;
+
 #if DEBUG
     isEnabled = NO;
 #endif
+
+    // TODO: Later, remove App Center SDK if Sentry is stable.
+
     // This method can only take effect after the service is started.
     [MSACCrashes setEnabled:isEnabled];