Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More categories #172

Open
wants to merge 2 commits into
base: 4.8.2
Choose a base branch
from
Open

Conversation

LoloIrie
Copy link

Allow to select more categories using a radio buttons list

@LoloIrie
Copy link
Author

Hi,

thanks for the nice plugin.
I need these both features... and maybe I'm not alone with this need. ;)
Feel free to comment if something need to be changed.

Cheers
Lolo Irie

@markkap
Copy link
Collaborator

markkap commented Feb 23, 2018

Hi @LoloIrie, thank you very much for the contribution, but

  1. Selecting categories with radio buttons IMHO do not scale well when you have many categories as it might generate a lot of UI clutter.

  2. Setting date range is actually a great idea. Not sure I like the implementation as you have done it (yes, every developer has to reinvent the wheel ;) ) as I think it is more useful to either specify "time back from now" or "starting at time" type of setting. Needs also some more thinking of how it integrates (or not at all) with the offset and number of posts settings as at least for me right now the number of posts might be kind of contradictory to this setting, or at least will need an option of "all". Will need to give some more thought to it.
    Another factor with not rushing to accept the PR is that you are the only one which showed interest in such a feature and we do not want to clutter the UI with features people are less likely to actually use.
    As I said, need to give some more thought to this....

@LoloIrie
Copy link
Author

Hi @markkap,

don't worry, I've just posted these PR if you want to use them or/and to give you new ideas...
If you don't want them or think it can not be implemented for any reason, no problem like I'm using a customized version of this plugin for my own use.

  1. A possible solution for the UI issue would be to use a container with fixed height and scroll effect, or/and use this multiple options in a dropdown menu, or/and allow this only if there are XX categories max...

  2. For the Date range option, my own experience (like it looks I'm the first one to need it)... is to have a start and a final dates... But sure it can be improved/modified. ;)

Anyway, thanks for your feedback.
Best regards
Lolo

@markkap
Copy link
Collaborator

markkap commented Feb 23, 2018

@LoloIrie do you mind sharing the scenario in which you want to have a specific date range? It just sound like something that in most sites will need a constant updating.

@LoloIrie
Copy link
Author

You're right, it could need constant updating (but only if you are using this feature like it is currently, because if you let it empty, no date range is used).
And of course an other extra option like you wrote to define dynamically start and end dates would be perfect.

My current case is to display a page "every year" for each team in our club, but start and end dates are not every year exactly the same. So I really need to set exactly the start and end dates.
I could use everytime new categories, but I will lost the option to display everything as global archive and I will get too much categories just for a date range issue...

I can imagine other scenarii where it will hepful, but maybe that's not si important for other users... Really no idea, and finally your choice to do it or not. ;)

Thanks one more time for your interest anyway ! :)

@markkap
Copy link
Collaborator

markkap commented Feb 23, 2018

Oh I see. I was thinking too much about the usage as a widget, but it makes perfect sense in a shortcode. Will give it a strong consideration for 4.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants