Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TINY-11252: Add terminal and network logging #146

Merged
merged 1 commit into from
Nov 10, 2024
Merged

TINY-11252: Add terminal and network logging #146

merged 1 commit into from
Nov 10, 2024

Conversation

jscasca
Copy link
Contributor

@jscasca jscasca commented Sep 25, 2024 •
edited
Loading

I don't think we need to hide this logging behind a CLI option

Related Ticket: TINY-11252

Description of Changes:

  • Enable terminal and network logging for lambdatest

Pre-checks:

  • Changelog entry added
  • package.json versions have not been changed (done by Lerna on release)
  • Tests have been added (if applicable)

Before merging:

  • Ensure internal dependencies are on appropriate versions
    • For stable releases, all dependencies must be stable
    • For release candidates, all dependencies must be release candidates or stable

@jscasca jscasca requested a review from a team as a code owner September 25, 2024 07:34
@jscasca
TINY-11252: Add terminal and network logging
f25b377 
I don't think we need to hide this logging behind a CLI option
@jscasca jscasca merged commit 07fdfff into master Nov 10, 2024
5 checks passed
@jscasca jscasca deleted the feature/TINY-11252 branch November 10, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spocke spocke spocke approved these changes

@TheSpyder TheSpyder TheSpyder approved these changes

@ArvinJ-H ArvinJ-H ArvinJ-H approved these changes

@MitchC1999 MitchC1999 MitchC1999 approved these changes

@tiny-ben-tran tiny-ben-tran tiny-ben-tran approved these changes

@shanmen-tiny shanmen-tiny shanmen-tiny approved these changes

@ltrouton ltrouton Awaiting requested review from ltrouton ltrouton is a code owner automatically assigned from tinymce/tinymce-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jscasca @spocke @TheSpyder @ArvinJ-H @MitchC1999 @tiny-ben-tran @shanmen-tiny