Bug in AdvancerList in conjunction with reduce operation without Identity #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce when the source was a list in conjunction with the reduce operation.
fmcarvalho
added a commit
that referenced
this pull request
Oct 30, 2020
…ach based on tryAdvance().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the reduce operation is called on a Query, where no Identity is passed and the source is an AdvancerList the first element is iterated twice.
Not sure if this solution is the most performant, but it fixes the problem.
Added a test to showcase the issue and to prevent this from happening again.