Skip to content

runtime: stub runtime signal functions for os/signal on wasip1 #4882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

dgryski
Copy link
Member

@dgryski dgryski commented May 2, 2025

No description provided.

@dgryski
Copy link
Member Author

dgryski commented May 2, 2025

For #4865

Copy link
Contributor

@eliasnaur eliasnaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

func signal_enable(uint32) {}

//go:linkname signal_ignore os/signal.signal_ignore

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the use of newlines between go:linknames and their functions is inconsistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants