-
Notifications
You must be signed in to change notification settings - Fork 951
Add sponsor button to key repositories #4521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5955dbf
to
460e4ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interestingly the CI for linux fails, although you did not touch this. I have the same issue in #4517, so dev
seems to be broken? Same for nix-test
.
The fix for nix is in... or at least for the CI. Please rebase against latest dev. |
460e4ca
to
fa22bc4
Compare
done, but now Linux/assert-test-linux fails :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/usr/bin/ld: ASTContext.cpp:(.text._ZL17DecodeTypeFromStrRPKcRKN5clang10ASTContextERNS3_19GetBuiltinTypeErrorERbb+0x670): undefined reference to `__isoc23_strtoul'
It looks to me as if there is still a version mismatch. The linker is unable to find the symbol __isoc23_strtoul
which I think is defined in glibc, so it looks like the glibc version is too old.
This PR doesn't change any code, so I'd suggest to just ignore the CI errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @conejoninja now merging. |
Add the sponsor button linking to open collective in the repository.
Needs to be enable ( https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/displaying-a-sponsor-button-in-your-repository )