Skip to content

Add sponsor button to key repositories #4521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

conejoninja
Copy link
Member

Copy link
Contributor

@leongross leongross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly the CI for linux fails, although you did not touch this. I have the same issue in #4517, so dev seems to be broken? Same for nix-test.

@leongross leongross mentioned this pull request Oct 14, 2024
@deadprogram deadprogram changed the base branch from release to dev October 17, 2024 13:58
@deadprogram
Copy link
Member

The fix for nix is in... or at least for the CI. Please rebase against latest dev.

@conejoninja
Copy link
Member Author

done, but now Linux/assert-test-linux fails :/

Copy link
Contributor

@leongross leongross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/usr/bin/ld: ASTContext.cpp:(.text._ZL17DecodeTypeFromStrRPKcRKN5clang10ASTContextERNS3_19GetBuiltinTypeErrorERbb+0x670): undefined reference to `__isoc23_strtoul'

It looks to me as if there is still a version mismatch. The linker is unable to find the symbol __isoc23_strtoul which I think is defined in glibc, so it looks like the glibc version is too old.

@aykevl
Copy link
Member

aykevl commented Oct 18, 2024

This PR doesn't change any code, so I'd suggest to just ignore the CI errors.
The CI errors are weird though, if they keep happening I think we should do a new llvm-build (by incrementing the cache key) to see whether that helps. It looks like a version mismatch indeed.

Copy link
Contributor

@leongross leongross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree @aykevl. Since we had some trouble in the past few days with the CI, I initially thought we should investigate this while we are debugging the CI. But on other PRs like #4517 this could not be observed, so let's get this merged.

@deadprogram
Copy link
Member

Thank you @conejoninja now merging.

@deadprogram deadprogram merged commit 3dcac3b into tinygo-org:dev Oct 22, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants