Modify the GetGlyph() interface to ensure that const2bit works properly #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Glypher for cases where different rendering, such as const2bit, is required This further modifies the changes made in 05eb156 No heap allocations occur Additionally, this change makes const2bit available
|
For example, you can create a font using const2bit as shown below. |
sago35
commented
Oct 18, 2024
|
I believe it was originally ready for review, but after a self-check, I only made corrections to func GetGlyph. Everything else should be fine. |
|
OK got it. Thanks for the improvement @sago35 now merging. Note that I switched this PR to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
Glypher intefacefor cases where different rendering, such as const2bit, is required.No heap allocations occur.
Additionally, this change makes const2bit available. (#43)