-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows: Remove requirement to use cgo #194
Conversation
cfaf280
to
8f4a230
Compare
@jagobagascon I am able to run the scanner on Windows without installing any CGo build tool with this PR. It runs the scanner exactly as expected, and does not display any errors. 😄 |
7dd1845
to
8f4a230
Compare
Seems to be working well enough for me. |
I don't think the error is going to be fixed anytime soon. And let's be real, tinygo-org/bluetooth is probably the only use case for saltosystems/winrt-go so, would you like us to merge saltosystems/winrt-go#60? If so, I think the PR should also include the "workaround" to avoid the deadlock error. I already made a change to include it: basically whenever a |
8f4a230
to
7907949
Compare
@jagobagascon tested saltosystems/winrt-go#60 and it worked perfectly. Once it is merged, I will replace the commit in this PR that updates the |
… CGo Signed-off-by: deadprogram <[email protected]>
Signed-off-by: deadprogram <[email protected]>
Signed-off-by: deadprogram <[email protected]>
b8e1d70
to
49654c5
Compare
Merging since has been pretty well tested. |
This PR is an attempt to remove the requirement for CGo when using Windows.
Based entirely on the fine work of @jagobagascon including the hack to get around golang/go#55015