Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hooked up Crashlytics #72

Merged
merged 4 commits into from
Aug 27, 2019
Merged

Hooked up Crashlytics #72

merged 4 commits into from
Aug 27, 2019

Conversation

or-else
Copy link
Contributor

@or-else or-else commented Aug 26, 2019

I had to directly edit it adding some of the changes from https://github.com/tidwall/SwiftWebSocket/pull/138/files, otherwise it would not compile.

@or-else or-else requested a review from aforge August 26, 2019 07:26
@aforge
Copy link
Collaborator

aforge commented Aug 27, 2019

Sweet!
Editing the web socket pod code is okay. I actually did something similar even for supporting 4.2.
So at some point in the future, we'll need to prioritize #14.

@or-else or-else merged commit 379031a into devel Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aforge aforge aforge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@or-else @aforge