deps: Move sanity to peer deps #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As `sanity` is a dependency, we get warnings whenever it's slightly behind on version. As a peer dependency, we're able to specify a range in which the package will work, but prevent version mismatches with end users if the `sanity-web` is not kept up to date with all Sanity releases. This equals less maintenance burden for this package and its maintainers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
sanityis a dependency, we get warnings whenever it's slightly behind on version.As a peer dependency, we're able to specify a range in which the package will work, but prevent version mismatches with end users if the
sanity-webis not kept up to date with all Sanity releases.This equals less maintenance burden for this package and its maintainers
$ pnpm i WARN Issues with peer dependencies found apps/sanity └─┬ @tinloof/sanity-studio 1.4.0 └─┬ @tinloof/sanity-web 0.6.0 └─┬ sanity 3.62.0 └─┬ @portabletext/editor 1.5.5 ├── ✕ unmet peer @sanity/block-tools@^3.63.0: found 3.62.0 in sanity ├── ✕ unmet peer @sanity/schema@^3.63.0: found 3.62.0 in sanity ├── ✕ unmet peer @sanity/types@^3.63.0: found 3.62.0 in sanity └── ✕ unmet peer @sanity/util@^3.63.0: found 3.62.0 in sanity packages/sanity-toolkit └─┬ @tinloof/sanity-studio 1.4.0 └─┬ @tinloof/sanity-web 0.6.0 └─┬ sanity 3.62.0 └─┬ @portabletext/editor 1.5.5 ├── ✕ unmet peer @sanity/block-tools@^3.63.0: found 3.62.0 in sanity ├── ✕ unmet peer @sanity/schema@^3.63.0: found 3.62.0 in sanity ├── ✕ unmet peer @sanity/types@^3.63.0: found 3.62.0 in sanity └── ✕ unmet peer @sanity/util@^3.63.0: found 3.62.0 in sanity