Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Template version constraint: #980

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Remove Template version constraint: #980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions internal/deprecated/workflow/template_validator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,6 @@ func validate(wf *Workflow) error {
return errors.Errorf(errInvalidLength, wf.Name)
}

if wf.Version != "0.1" {
return errors.Errorf("invalid template version (%s)", wf.Version)
}

if len(wf.Tasks) == 0 {
return errors.New("template must have at least one task defined")
}
Expand Down
11 changes: 0 additions & 11 deletions internal/deprecated/workflow/template_validator_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,6 @@ func TestValidateTemplate(t *testing.T) {
wf: toWorkflow(withTemplateLongName()),
expectedError: true,
},
{
name: "template version is invalid",
wf: toWorkflow(withTemplateInvalidVersion()),
expectedError: true,
},
{
name: "template tasks is nil",
wf: toWorkflow(withTemplateNilTasks()),
Expand Down Expand Up @@ -255,12 +250,6 @@ func withTemplateLongName() workflowModifier {
}
}

func withTemplateInvalidVersion() workflowModifier {
return func(wf *Workflow) {
wf.Version = "0.2"
}
}

func withTemplateNilTasks() workflowModifier {
return func(wf *Workflow) {
wf.Tasks = nil
Expand Down
Loading