-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Builtin workflow features #1000
Draft
jacobweinstock
wants to merge
10
commits into
tinkerbell:main
Choose a base branch
from
jacobweinstock:builtin-workflow-features
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP: Builtin workflow features #1000
jacobweinstock
wants to merge
10
commits into
tinkerbell:main
from
jacobweinstock:builtin-workflow-features
+852
−1,296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add spec field and functionality for setting the allowPXE field in hardware. Add spec field and functionality for creating a job.bmc.tinkerbell.org object to get the Hardware into a netboot state. Signed-off-by: Jacob Weinstock <[email protected]>
Use status' to make sure creation and deletion work properly. Signed-off-by: Jacob Weinstock <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1000 +/- ##
==========================================
+ Coverage 28.04% 28.86% +0.81%
==========================================
Files 70 70
Lines 3484 3607 +123
==========================================
+ Hits 977 1041 +64
- Misses 2445 2497 +52
- Partials 62 69 +7 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
related to tinkerbell/roadmap#33 |
Add tests for handleOneTimeNetboot and handleHardwareAllowPXE. Signed-off-by: Jacob Weinstock <[email protected]>
Hopefully improved the understandability of the field some. Signed-off-by: Jacob Weinstock <[email protected]>
Update rbac. Signed-off-by: Jacob Weinstock <[email protected]>
Upgrades and removed unused dep. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Pin apk packages in all Dockerfiles. Signed-off-by: Jacob Weinstock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is still a work in progress. This adds the fields in the Workflow spec to trigger handling of setting hardware
allowPxe
field and getting machines into a netbooting state.Current Workflow spec:
New Workflow spec:
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: