Fix linting warnings:

Pin apk packages in all Dockerfiles. Signed-off-by: Jacob Weinstock <[email protected]>
tinkerbell · Sep 20, 2024 · 6bea9cc · 6bea9cc
1 parent 86d057b
commit 6bea9cc
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 11 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -84,10 +84,6 @@ linters-settings:
       - name: struct-tag
         arguments:
           - "json,inline"
-  staticcheck:
-    go: "1.18"
-  unused:
-    go: "1.18"
 output:
   sort-results: true
 linters:
@@ -103,7 +99,7 @@ linters:
     - errname
     - errorlint
     - exhaustive
-    - exportloopref
+    - copyloopvar
     - forcetypeassert
     - gocognit
     - goconst

diff --git a/cmd/tink-agent/Dockerfile b/cmd/tink-agent/Dockerfile
@@ -3,7 +3,7 @@ FROM alpine:3.20.3
 ARG TARGETOS
 ARG TARGETARCH
 
-RUN apk add --no-cache --update --upgrade ca-certificates
+RUN apk add --no-cache --update --upgrade ca-certificates=20240705-r0
 
 COPY bin/tink-agent-${TARGETOS}-${TARGETARCH} /usr/bin/tink-agent
 

diff --git a/cmd/tink-controller-v1alpha2/Dockerfile b/cmd/tink-controller-v1alpha2/Dockerfile
@@ -3,7 +3,7 @@ FROM alpine:3.20.3
 ARG TARGETOS
 ARG TARGETARCH
 
-RUN apk add --no-cache --update --upgrade ca-certificates
+RUN apk add --no-cache --update --upgrade ca-certificates=20240705-r0
 
 COPY bin/tink-controller-v1alpha2-${TARGETOS}-${TARGETARCH} /usr/bin/tink-controller
 

diff --git a/cmd/tink-controller/Dockerfile b/cmd/tink-controller/Dockerfile
@@ -3,7 +3,7 @@ FROM alpine:3.20.3
 ARG TARGETOS
 ARG TARGETARCH
 
-RUN apk add --no-cache --update --upgrade ca-certificates
+RUN apk add --no-cache --update --upgrade ca-certificates=20240705-r0
 
 COPY bin/tink-controller-${TARGETOS}-${TARGETARCH} /usr/bin/tink-controller
 

diff --git a/cmd/tink-server/Dockerfile b/cmd/tink-server/Dockerfile
@@ -5,7 +5,7 @@ ARG TARGETARCH
 
 EXPOSE 42113 42114
 
-RUN apk add --no-cache --update --upgrade ca-certificates
+RUN apk add --no-cache --update --upgrade ca-certificates=20240705-r0
 
 COPY bin/tink-server-${TARGETOS}-${TARGETARCH} /usr/bin/tink-server
 

diff --git a/cmd/tink-worker/Dockerfile b/cmd/tink-worker/Dockerfile
@@ -3,7 +3,7 @@ FROM alpine:3.20.3
 ARG TARGETOS
 ARG TARGETARCH
 
-RUN apk add --no-cache --update --upgrade ca-certificates
+RUN apk add --no-cache --update --upgrade ca-certificates=20240705-r0
 
 COPY bin/tink-worker-${TARGETOS}-${TARGETARCH} /usr/bin/tink-worker
 

diff --git a/cmd/virtual-worker/Dockerfile b/cmd/virtual-worker/Dockerfile
@@ -3,7 +3,7 @@ FROM alpine:3.20.3
 ARG TARGETOS
 ARG TARGETARCH
 
-RUN apk add --no-cache --update --upgrade ca-certificates
+RUN apk add --no-cache --update --upgrade ca-certificates=20240705-r0
 
 COPY bin/virtual-worker-${TARGETOS}-${TARGETARCH} /usr/bin/virtual-worker