-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update iPXE commit to latest: #102
Conversation
I found an issue with the version of iPXE and downloading the Hook initramfs. This was found when using vagrant + libvirt from the Tinkerbell sandbox. I was not able to pin down the exact issue, but upgrading to this version showed that the issue was resolved. Signed-off-by: Jacob Weinstock <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #102 +/- ##
=======================================
Coverage 97.28% 97.28%
=======================================
Files 5 5
Lines 442 442
=======================================
Hits 430 430
Misses 8 8
Partials 4 4 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 1d909ee |
I was able to dig into this more and found the issue to not be just related to the iPXE version. in Jan of 2023 iPXE updated its default max TCP window size from 256kb to 2mb (ipxe/ipxe#863). In the Tinkerbell sandbox using Vagrant + Libvirt, all commits of iPXE before this change functioned without issue. From this commit and forward the issue is present. For the moment I've stopped investigating the issue more and have disabled TCP offloading on the VM that I create to run the Tinkerbell stack. This resolves the issue. I believe the virtual hardware, its version, configuration, etc to likely be factors. I havent been able to reproduce the issue with any real physical hardware. |
🤔 I think we may have run into this. We repeatedly reverted updates to iPXE for boot failures that may have also been issues with downloading kernel/initramfs images. I'll see if I can find specific hardware that can reproduce the issue. |
Description
I found an issue with the current version of iPXE we're using when downloading the Hook initramfs. This was found when using vagrant + libvirt from the Tinkerbell sandbox. I was not able to pin down the exact issue, but upgrading to this version showed that the issue was resolved.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: