Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iPXE commit to latest: #102

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

jacobweinstock
Copy link
Member

Description

I found an issue with the current version of iPXE we're using when downloading the Hook initramfs. This was found when using vagrant + libvirt from the Tinkerbell sandbox. I was not able to pin down the exact issue, but upgrading to this version showed that the issue was resolved.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

I found an issue with the version of
iPXE and downloading the Hook initramfs.
This was found when using vagrant + libvirt
from the Tinkerbell sandbox. I was not able to
pin down the exact issue, but upgrading to this
version showed that the issue was resolved.

Signed-off-by: Jacob Weinstock <[email protected]>
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #102 (63e46d0) into main (50efee0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   97.28%   97.28%           
=======================================
  Files           5        5           
  Lines         442      442           
=======================================
  Hits          430      430           
  Misses          8        8           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chrisdoherty4 chrisdoherty4 added the ready-to-merge Mergify: Ready for Merging label Oct 30, 2023
@jacobweinstock
Copy link
Member Author

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Oct 30, 2023

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 1d909ee

@mergify mergify bot merged commit 1d909ee into tinkerbell:main Oct 30, 2023
6 checks passed
@jacobweinstock jacobweinstock deleted the update-ipxe branch October 30, 2023 23:33
@jacobweinstock
Copy link
Member Author

I was able to dig into this more and found the issue to not be just related to the iPXE version. in Jan of 2023 iPXE updated its default max TCP window size from 256kb to 2mb (ipxe/ipxe#863). In the Tinkerbell sandbox using Vagrant + Libvirt, all commits of iPXE before this change functioned without issue. From this commit and forward the issue is present. For the moment I've stopped investigating the issue more and have disabled TCP offloading on the VM that I create to run the Tinkerbell stack. This resolves the issue. I believe the virtual hardware, its version, configuration, etc to likely be factors. I havent been able to reproduce the issue with any real physical hardware.

@nshalman
Copy link
Member

I was able to dig into this more and found the issue to not be just related to the iPXE version. in Jan of 2023 iPXE updated its default max TCP window size from 256kb to 2mb (ipxe/ipxe#863). In the Tinkerbell sandbox using Vagrant + Libvirt, all commits of iPXE before this change functioned without issue. From this commit and forward the issue is present. For the moment I've stopped investigating the issue more and have disabled TCP offloading on the VM that I create to run the Tinkerbell stack. This resolves the issue. I believe the virtual hardware, its version, configuration, etc to likely be factors. I havent been able to reproduce the issue with any real physical hardware.

🤔 I think we may have run into this. We repeatedly reverted updates to iPXE for boot failures that may have also been issues with downloading kernel/initramfs images. I'll see if I can find specific hardware that can reproduce the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Mergify: Ready for Merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants