Convert images to optimized formats #50
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…task/format-conversion
…task/format-conversion
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the feature to convert images to optimized formats (WebP/AVIF) by integrating Tinify API functionality and updating the integration tests accordingly.
- Added conversion settings tests to settings.spec.ts.
- Introduced a new conversion.spec.ts to verify conversion behavior and display.
- Updated bulkoptimization.spec.ts to incorporate conversion settings.
Reviewed Changes
Copilot reviewed 17 out of 34 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/integration/settings.spec.ts | Added tests for conversion settings in the image optimization workflow. |
| test/integration/conversion.spec.ts | New tests to verify image conversion functionality and display. |
| test/integration/bulkoptimization.spec.ts | Adjusted imports to include conversion settings for bulk optimizations. |
Files not reviewed (17)
- .vscode/launch.json: Language not supported
- src/class-tiny-compress-client.php: Language not supported
- src/class-tiny-compress-fopen.php: Language not supported
- src/class-tiny-compress.php: Language not supported
- src/class-tiny-helpers.php: Language not supported
- src/class-tiny-image-size.php: Language not supported
- src/class-tiny-image.php: Language not supported
- src/class-tiny-picture.php: Language not supported
- src/class-tiny-plugin.php: Language not supported
- src/class-tiny-settings.php: Language not supported
- src/config/class-tiny-config.php: Language not supported
- src/css/admin.css: Language not supported
- src/views/compress-details.php: Language not supported
- src/views/settings.php: Language not supported
- test/helpers/mock-http-stream-wrapper.php: Language not supported
- test/helpers/mock-tinify-client.php: Language not supported
- test/helpers/wordpress.php: Language not supported
rkoopmans
reviewed
May 14, 2025
src/class-tiny-bulk-optimization.php
Outdated
| $stats['optimized-image-sizes'] += $image_stats['image_sizes_optimized']; | ||
| $stats['optimized-library-size'] += $image_stats['optimized_total_size']; | ||
| if ( $conversion_enabled ) { | ||
| $stats['available-unoptimised-sizes'] += |
There was a problem hiding this comment.
Because it sucks to change it later, stick with one spelling (optimized)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With file conversion enabled customers can choose to generate an additional image in a modern format. WebP and AVIF are known to produce a better quality and performance image. Unfortunately, not all browsers support it 100% so therefor we choose to supply it as an addition instead of replacing the image.
Screenshots
Conversion is (for now) enabled by default. It will cost one additional compression per image.
We show the optimized file and the size in the details tab.
Further Improvements
Below are options/features that can be added to this feature. Discussion is open to see if these are all could haves or if some of them are must haves.