Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for unknown command line flags issue #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kristijanbartol
Copy link

Fix for missing flags, for example:
"absl.flags._exceptions.UnrecognizedFlagError: Unknown command line flag 'num_source'"

@xiongdemao
Copy link

hi!friend,may i have a question about which python version about this project ?

@Yuzz1020
Copy link

Hi! I am facing the same problem. Is there any solution to this problem now? The environment I am using is python 2.7.15, tensorflow 1.6.

Copy link
Owner

@tinghuiz tinghuiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Thanks for the PR! Some comments below.
'num_source' is supposed to be derived from 'seq_length' (i.e. fixed to be seq_length - 1), and 'num_scales' is also fixed to be 4. So neither of them is really supposed to be specified as an input argument. I actually haven't figured out why the current code throws errors on some machines but not on others (e.g. several machines I tested on before the code release). I suspect it's an issue with different tensorflow versions. If you know of the cause, please let me know and I'll see if there's an easy fix.

@JoeFang123
Copy link

Maybe you could add two members in FLAGS like this
flags.DEFINE_integer("num_source", None, "number of source images")
flags.DEFINE_integer("num_scales", None, "number of used image scales")
in the train.py

zacr0 added a commit to zacr0/GeoNet that referenced this pull request Nov 19, 2018
Added missing declarations for 'num_source', 'num_scales', 'add_posenet', 'add_dispnet' and 'add_flownet', which seems they must be declared before using them in newer Tensowflow versions.

Source: tinghuiz/SfMLearner#70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants