Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nx inputs for build to ensure lint works properly #226

Merged
merged 1 commit into from
May 31, 2024

Conversation

beaussan
Copy link
Contributor

@beaussan beaussan commented May 31, 2024

To ensure the dependancy-checks rules works properly, you need to have inputs that don't includes tests files.

The rule uses the project graph to collect all the dependencies of your project, based on the input of your build target. It will filter out all the dependencies marked as devDependencies in your root package.json to ensure dependencies of your compilation pipelines (e.g. dependencies of webpack.config or vite.config) or test setups are not included in the expected list.

@beaussan beaussan changed the base branch from develop to fix/release May 31, 2024 07:57
@beaussan beaussan marked this pull request as ready for review May 31, 2024 08:00
@tinesoft tinesoft merged commit 2a0ec4d into tinesoft:fix/release May 31, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants