Making gradio private by default, and adding --public argument #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…default to private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be more of a matter of opinion, so feel free to reject this if it doesn't fit.
Basically, I noticed that when I run edit_app.py gradio automatically runs a public link accessible from the inernet, and the only way to turn it off was to edit the code. I thought this could potentially be insecure to have it as the default behavior, since there are a lot of people using this who may not understand the implications.
I made the default behavior of edit_app.py gradio to be a private link, and I added a --public arg in case anyone wants to make their app accessible from anywhere.
Thank you.