Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS Paper Edits #82

Merged
merged 4 commits into from
Nov 12, 2024
Merged

JOSS Paper Edits #82

merged 4 commits into from
Nov 12, 2024

Conversation

timothyas
Copy link
Owner

@timothyas timothyas commented Nov 12, 2024

Addressing @crvernon's comments

  • LINE 1: The "p" in "python" should be capitalized.
  • Throughout, including the title, Dask should have a capital "D" unless you are referring to a specific usage in code. The same goes for Xarray.

@timothyas
Copy link
Owner Author

Paper typos addressed

(base) [tim xesn]$ grep python paper.md 
(base) [tim xesn]$ grep xarray paper.md
  - xarray
familiar to weather and climate scientists such as `Xarray` [@hoyer_xarray_2017].
level operations with `Xarray` [@hoyer_xarray_2017].
(base) [tim xesn]$ grep dask paper.md 
  - dask
[@dask_2016; @rocklin_scipy_2015]
We then create 3 different `dask.distributed` Clusters, testing:
   `dask.distributed.LocalCluster` has 6 workers, each with 5 threads.
   `dask_cuda.LocalCUDACluster` has 8 workers, each

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.20%. Comparing base (71c280c) to head (db64a2f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files          11       11           
  Lines        1029     1029           
=======================================
  Hits          990      990           
  Misses         39       39           
Flag Coverage Δ
unittests 96.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timothyas
Copy link
Owner Author

Had to update the workflows to use SMT version < 2.8.0 since this new release has a bug of some sort (TBD). Also, not critical yet, but this updates all the GHA versions that were flagged as deprecated.

@timothyas timothyas merged commit 86524bc into main Nov 12, 2024
5 checks passed
@timothyas timothyas deleted the feature/final-joss-edits branch November 12, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants