-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continue Create Dropdown Options #946
base: main
Are you sure you want to change the base?
Conversation
@spiteless is attempting to deploy a commit to the timlrx's projects Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks for picking up and continuing this work. There's a build error:
|
Styling wise, I would leave it up to you to decide what works best for mobile :) |
Good to know this is moving in the right direction. I'd like to make another attempt at getting the styling better, I'll update this in a few days again. |
Actually this PR is almost good to go. I wouldn't mind indicating the dropdown menu options with a chevron like the shadcn components and changing the behaviour from onClick to onHover. Other than that @spiteless, let me know when you have some time to polish up the mobile component and we can merge it? Thanks! |
Gotcha, will add the Chevron and onHover Just need to find the time to update the mobile menu styling render |
Enhancement
Continuation of #897
Changes
headerNavLinks
Code structure
NavOptions
,MobileNav
data/headerNavLinks.ts
, feels like the wrong spot for typesVisuals
With Changes