Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue Create Dropdown Options #946

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

trillium
Copy link
Contributor

@trillium trillium commented Jun 22, 2024

Enhancement

Continuation of #897

Changes

  • Add support for dropdown within headerNavLinks
  • Update dropdown styling in MobileNav
    • Iffy on this being the right styling of the menu

Code structure

  • Use helper functions to render navs within NavOptions, MobileNav
  • Create NavLinks types
    • Defined in data/headerNavLinks.ts, feels like the wrong spot for types

Visuals

With Changes image image

Copy link

vercel bot commented Jun 22, 2024

@spiteless is attempting to deploy a commit to the timlrx's projects Team on Vercel.

A member of the Team first needs to authorize it.

@trillium trillium closed this Jun 22, 2024
@trillium trillium reopened this Jun 22, 2024
Copy link

vercel bot commented Jun 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tailwind-nextjs-starter-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 3:02pm

@trillium trillium changed the title Ts.continue feature dropdown Continue Create Feature Dropdown Jun 22, 2024
@trillium trillium changed the title Continue Create Feature Dropdown Continue Create Dropdown Options Jun 22, 2024
@timlrx
Copy link
Owner

timlrx commented Jun 23, 2024

Thanks for picking up and continuing this work. There's a build error:

./components/MobileNav.tsx:109:44
Type error: An interface can only extend an object type or intersection of object types with statically known members.
  107 | export default MobileNav
  108 |
> 109 | interface RenderMobileNavLinkProps extends NavItem {
      |                                            ^
  110 |   clickFunc: () => void
  111 |   navLink: NavItem
  112 | }
Error: Command "yarn run build" exited with 1

data/headerNavLinks.ts Show resolved Hide resolved
data/headerNavLinks.ts Outdated Show resolved Hide resolved
components/MobileNav.tsx Outdated Show resolved Hide resolved
@timlrx
Copy link
Owner

timlrx commented Jun 23, 2024

Styling wise, I would leave it up to you to decide what works best for mobile :)

@trillium
Copy link
Contributor Author

Good to know this is moving in the right direction. I'd like to make another attempt at getting the styling better, I'll update this in a few days again.

@abernier
Copy link
Contributor

@timlrx
Copy link
Owner

timlrx commented Jul 10, 2024

Actually this PR is almost good to go. I wouldn't mind indicating the dropdown menu options with a chevron like the shadcn components and changing the behaviour from onClick to onHover. Other than that @spiteless, let me know when you have some time to polish up the mobile component and we can merge it? Thanks!

@trillium
Copy link
Contributor Author

Gotcha, will add the Chevron and onHover

Just need to find the time to update the mobile menu styling render

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants