Add missing elog(DEBUG2,...) after refactoring #7575
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziomello
added
continuous_aggregate
tech-debt
In timescale#7505 we refactored the materialization code but the debugging query was removed by accident. Disable-check: force-changelog-file Disable-check: approval-count
fabriziomello
force-pushed
the
cagg_debug_query_on_materialization
branch
from
debb73c to
d9a5a5a
Compare
akuzm
approved these changes
Jan 7, 2025
mkindahl
reviewed
Jan 8, 2025
| @@ -633,6 +633,7 @@ create_materialization_plan(MaterializationContext *context, MaterializationPlan | |||
| char *query = materialization->create_statement(context); | |||
| Oid types[] = { context->materialization_range.type, context->materialization_range.type }; | |||
|
|
|||
| elog(DEBUG2, "%s: %s", __func__, query); | |||
There was a problem hiding this comment.
I added a macro TS_DEBUG_LOG for these kinds of situations. It will be removed for release builds, so that we do not laden the server for debug printouts unnecessarily.
There was a problem hiding this comment.
Sometimes I need this DEBUG2 for debugging production materialization queries produced by our refresh cagg code (specially on SDCs). And actually we had it already before the refactoring, just bringing it back to the new code.
There was a problem hiding this comment.
If it is needed for debugging production code, then TS_DEBUG_LOG should not be used. Agree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7505 we refactored the materialization code but the debugging query was removed by accident.
Disable-check: force-changelog-file
Disable-check: approval-count