Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use hash grouping w/o keys in chunkwise aggregation #7552

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

akuzm
Copy link
Member

@akuzm akuzm commented Dec 19, 2024

In chunkwise aggregation paths, we cannot use hash aggregation in FinalizeAggregate without grouping, because it leads to a wrong result in case when there are no input rows. Use the strategy type flags set by the Postgres planner.

Disable-check: force-changelog-file

It leads to a wrong result in case when there are no input rows. Use the
strategy type flags set by the Postgres planner.
@akuzm akuzm changed the title Don't use hash grouping w/o keys Don't use hash grouping w/o keys in chunkwise aggregation Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.23%. Comparing base (59f50f2) to head (7e41712).
Report is 673 commits behind head on main.

Files with missing lines Patch % Lines
tsl/src/chunkwise_agg.c 25.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7552      +/-   ##
==========================================
+ Coverage   80.06%   82.23%   +2.16%     
==========================================
  Files         190      238      +48     
  Lines       37181    43716    +6535     
  Branches     9450    10968    +1518     
==========================================
+ Hits        29770    35949    +6179     
- Misses       2997     3432     +435     
+ Partials     4414     4335      -79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akuzm akuzm marked this pull request as ready for review December 23, 2024 13:49
@akuzm akuzm enabled auto-merge (squash) January 6, 2025 10:41
@akuzm akuzm merged commit 487898c into timescale:main Jan 6, 2025
48 of 50 checks passed
@akuzm akuzm deleted the empty-hash branch January 6, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants