Add index creation on orderby columns #7436
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkindahl, @akuzm: please review this pull request.
|
|
Lets make sure we don't run segmentwise recompression on chunks without segmentby because currently its suboptimal vs doing a full recompress. |
kpan2034
force-pushed
the
compression-indexes
branch
from
cf5d71c to
b68e994
Compare
antekresic
requested changes
Nov 26, 2024
kpan2034
force-pushed
the
compression-indexes
branch
from
b68e994 to
36f796f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7436 +/- ##
==========================================
+ Coverage 80.06% 82.28% +2.21%
==========================================
Files 190 238 +48
Lines 37181 43725 +6544
Branches 9450 10971 +1521
==========================================
+ Hits 29770 35978 +6208
- Misses 2997 3405 +408
+ Partials 4414 4342 -72 ☔ View full report in Codecov by Sentry. |
kpan2034
force-pushed
the
compression-indexes
branch
6 times, most recently
from
12331c5 to
36d03d6
Compare
Previously, for chunks without a segmentby column specified in the compression settings, no indexes were created. This change allows indexes to be created on orderby columns only in this scenario. Since there is no segmentby in the compression settings for these chunks we also disable segmentwise recompression for them as it is more optimal to do a full recompression in this case.
kpan2034
force-pushed
the
compression-indexes
branch
from
36d03d6 to
0e14a8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, for chunks without a segmentby column specified in the compression settings, no indexes were created. This change allows indexes to be created on orderby columns only in this scenario.